rusackas commented on PR #36214:
URL: https://github.com/apache/superset/pull/36214#issuecomment-5787610561
Rebased onto current master and reworked the fix based on the review here.
The original version re-sorted each series' already-built data array, matching
its shape by hand, which missed a real case: `transformSeries` wraps points as
`{ value: [x, y], itemStyle }` when colorByPrimaryAxis is on, before this code
ever saw them, so those charts were never actually getting reordered.
Now it sorts the raw query records once, before extractSeries builds
anything, so every downstream shape (series data, stacked totals, legend) sees
one consistently ordered source instead of needing to be special-cased. Scoped
to category axes only; Bar is excluded since its category order turned out to
be a deliberate, source-preserving contract independent of legend sorting
(there's an existing test for that). Replied to each open thread individually
with what changed. Also added BigInt-safe comparison for large numeric-like IDs
and dropped a defensive mutation on a shared formatter singleton that never
actually did anything (NumberFormatter's `id` is a required constructor field).
CI's running on the new commit now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
