aminghadersohi commented on PR #43770:
URL: https://github.com/apache/superset/pull/43770#issuecomment-5792232815
@rusackas heads up — this grew after your approval, so flagging rather than
sneaking it through.
Merging master picked up #44495, which routes MCP response values through
`base_json_conv` → `float(obj)`. That turns `Decimal("0.10000000000000000001")`
into `0.1` silently, which this PR has a test specifically forbidding.
Rather than drop the test, the fix went into the shared sanitizer
(`superset/mcp_service/utils/serialization.py`): finite Decimals are preserved
exactly, non-finite still serialize as `null`. Because pydantic has no exact
JSON-*number* path for Decimal, preserved values go out as JSON strings — so
Decimal columns change shape in `get_chart_data`, `get_dashboard_data`,
`query_dataset`, `get_table` and `execute_sql`. Documented in UPDATING.md.
It's isolated in e7b105e5 if you'd prefer it split into its own PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
