rusackas commented on code in PR #43666:
URL: https://github.com/apache/superset/pull/43666#discussion_r4081065732
##########
superset/dashboards/schemas.py:
##########
@@ -596,7 +601,7 @@ class GetFavStarIdsSchema(Schema):
class ImportV1DashboardSchema(Schema):
dashboard_title = fields.String(required=True)
description = fields.String(allow_none=True)
- css = fields.String(allow_none=True)
+ css = fields.String(allow_none=True, validate=validate_css)
Review Comment:
@sadpandajoe fair point on the round trip. Left it strict on purpose though:
a bundle is not the same trust level as an existing row, could be from another
instance or a stale/tampered export, so there is nothing safe to compare
"unchanged" against. Added a comment in the schema spelling that out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
