aminghadersohi commented on code in PR #43723:
URL: https://github.com/apache/superset/pull/43723#discussion_r4079555782
##########
superset/examples/sales_dashboard/charts/Total_Items_Sold_By_Product_Line.yaml:
##########
@@ -26,7 +26,7 @@ params:
color_pn: true
datasource: 23__table
granularity_sqla: order_date
- groupby:
+ columns:
Review Comment:
In aggregate mode `extractQueryFields:76` drops a literal `columns` key,
*before* the groupby->columns rename at :89. Executed via real
`buildQueryObject`: ['product_line'] -> [], so this chart loses its dimension.
The repo's own test "should ignore columns when in aggregate QueryMode" pins it.
```suggestion
groupby:
```
##########
superset/examples/fcc_new_coder_survey/charts/Highest_degree_held.yaml:
##########
@@ -35,7 +35,7 @@ params:
color_pn: true
datasource: 42__table
granularity_sqla: time_start
- groupby:
+ columns:
Review Comment:
In aggregate mode `extractQueryFields:76` drops a literal `columns` key,
*before* the groupby->columns rename at :89. Executed via real
`buildQueryObject`: ['school_degree'] -> [], so this chart loses its dimension.
The repo's own test "should ignore columns when in aggregate QueryMode" pins it.
```suggestion
groupby:
```
##########
superset/examples/slack_dashboard/charts/Top_Timezones.yaml:
##########
@@ -27,7 +27,7 @@ params:
color_pn: true
datasource: 31__table
granularity_sqla: updated
- groupby:
+ columns:
Review Comment:
In aggregate mode `extractQueryFields:76` drops a literal `columns` key,
*before* the groupby->columns rename at :89. Executed via real
`buildQueryObject`: ['tz'] -> [], so this chart loses its dimension. The repo's
own test "should ignore columns when in aggregate QueryMode" pins it.
```suggestion
groupby:
```
##########
superset/examples/fcc_new_coder_survey/charts/Top_15_Languages_Spoken_at_Home.yaml:
##########
@@ -35,7 +35,7 @@ params:
color_pn: true
datasource: 42__table
granularity_sqla: time_start
- groupby:
+ columns:
Review Comment:
In aggregate mode `extractQueryFields:76` drops a literal `columns` key,
*before* the groupby->columns rename at :89. Executed via real
`buildQueryObject`: ['lang_at_home'] -> [], so this chart loses its dimension.
The repo's own test "should ignore columns when in aggregate QueryMode" pins it.
```suggestion
groupby:
```
##########
superset/examples/fcc_new_coder_survey/charts/Breakdown_of_Developer_Type.yaml:
##########
@@ -26,7 +26,7 @@ params:
color_pn: true
datasource: 42__table
granularity_sqla: time_start
- groupby:
+ columns:
Review Comment:
In aggregate mode `extractQueryFields:76` drops a literal `columns` key,
*before* the groupby->columns rename at :89. Executed via real
`buildQueryObject`: ['developer_type'] -> [], so this chart loses its
dimension. The repo's own test "should ignore columns when in aggregate
QueryMode" pins it.
```suggestion
groupby:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
