EnxDev opened a new pull request, #44574: URL: https://github.com/apache/superset/pull/44574
### SUMMARY `babel-extract` is failing on master and therefore on every open PR: ``` superset/translations/messages.pot is out of sync with source: 1 string(s) in source are missing from the template, 1 string(s) in the template no longer exist in source. ``` #44036 reworded the connection-move error in `superset/commands/database/exceptions.py` so that it also covers OAuth2 endpoint URIs and the OAuth2 client secret, but the extraction was not re-run. The committed template kept the old wording, so `scripts/translations/check_pot_drift.py` sees one string in source that is not in the template and one in the template that is no longer in source. That check runs before anything else in the job, so the whole `babel-extract` job stops there. Because CI builds the merge ref, this fails on PRs that do not touch Python or translations at all. It is currently red on the tip of master ([7dd70ea](https://github.com/apache/superset/commit/7dd70eaf2d)). The fix is the one the failure message asks for: `./scripts/translations/babel_update.sh`, with the regenerated template and catalogs committed. The only content change is that one msgid, propagated from the template into the 30 language catalogs: ```diff msgid "" "This update would change the connection's effective destination " -"(host/port, engine parameters, or SSH tunnel endpoint) while reusing the " -"stored credential. Provide the real password (or SSH tunnel credential) " -"to confirm a connection move." +"(host/port, engine parameters, SSH tunnel endpoint, or OAuth2 endpoint " +"URIs) while reusing the stored credential. Provide the real password (or " +"SSH tunnel credential / OAuth2 client secret) to confirm a connection " +"move." msgstr "" ``` No translation is stranded by the reword. The string is new enough that no catalog had translated it, so every `msgstr` on both sides of the change is empty. The rest of the diff is the `POT-Creation-Date` stamp that the script rewrites in each file. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable. ### TESTING INSTRUCTIONS ```bash python scripts/translations/check_pot_drift.py ``` On master this exits 1 and prints the two drifted strings. On this branch it exits 0 with `superset/translations/messages.pot matches a fresh extraction.` To confirm the regeneration is reproducible rather than hand-edited, re-run the script and check that nothing changes: ```bash ./scripts/translations/babel_update.sh git diff --stat # only POT-Creation-Date, which is stamped with the current time ``` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
