bito-code-review[bot] commented on code in PR #44148:
URL: https://github.com/apache/superset/pull/44148#discussion_r4080875529
##########
superset/translations/uk/LC_MESSAGES/messages.po:
##########
@@ -7997,6 +8009,10 @@ msgstr "Стовпець GeoJSON"
msgid "GeoJson Settings"
msgstr "Параметри GeoJSON"
+#, python-format
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Wrong gettext format flag</b></div>
<div id="fix">
The `#, python-format` flag is wrong for this msgid. The source is JS
`t('Geographic metric %s must be a finite number', label)` in
`transformData.ts:93`; the Python source `query_result.py:287` uses an f-string
`{label!r}`, not `%s`. Mislabeling the format flag can mislead translators and
trip gettext format validation. Use `#, javascript-format`.
</div>
</div>
<small><i>Code Review Run #11228f</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
