bito-code-review[bot] commented on code in PR #44554:
URL: https://github.com/apache/superset/pull/44554#discussion_r4080685642
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -239,6 +249,7 @@ function BigNumberVis({
fontSize,
height: 'auto',
color: numberColor,
+ textAlign: headerAlignment,
Review Comment:
<!-- Bito Reply -->
The suggestion is appropriate and improves the code by correctly aligning
the big number within the flex container. Using `justifyContent` is the correct
approach for positioning items in a flex container, whereas `textAlign` is
ineffective for flex items. Applying this change ensures consistent alignment
behavior.
**superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx**
```
fontSize,
height: 'auto',
color: numberColor,
justifyContent: headerAlignment,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
