rusackas commented on PR #43499: URL: https://github.com/apache/superset/pull/43499#issuecomment-5796365076
Looks like #43500 solved the underlying #29697 crash the other way, rejecting `saved_query`/`query` as chart datasources instead of making them work, and #44416 locked that in with an explicit TABLE/SEMANTIC_VIEW allowlist. That's why `validate_chart_datasource_type` now rejects `saved_query` on `master`, and this PR's own regression test fails after a rebase. Still worth landing, or close this in favor of #43500? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
