codeant-ai-for-open-source[bot] commented on code in PR #44577:
URL: https://github.com/apache/superset/pull/44577#discussion_r4084088748
##########
superset/dashboards/filter_scope.py:
##########
@@ -57,8 +60,15 @@
def build_chart_layout_items(position_data: dict[str, Any]) ->
ChartLayoutItems:
- """Map each chart id in the layout to the layout items that render it."""
+ """Map each chart id in the layout to the layout items that render it.
+
+ A layout that is not a mapping (``position_json`` holding a JSON string or
+ array) places no charts, so every derived scope comes out empty.
+ """
chart_layout_items: ChartLayoutItems = {}
+ if not isinstance(position_data, dict):
+ logger.warning("Dashboard layout is not a mapping; no charts are in
scope")
+ return chart_layout_items
Review Comment:
**Suggestion:** Returning an empty layout map does not empty selected-layer
scopes: `get_chart_ids_in_scope` bypasses layout membership and still returns
targeted chart IDs for malformed layouts.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7d449796c1334957a79293031dcfbce3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7d449796c1334957a79293031dcfbce3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/dashboards/filter_scope.py
**Line:** 69:71
**Comment:**
*Api Mismatch: Returning an empty layout map does not empty
selected-layer scopes: `get_chart_ids_in_scope` bypasses layout membership and
still returns targeted chart IDs for malformed layouts.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44577&comment_hash=26501e3b991dc772a7bf296aa50a587a14e32533b4870591f6dc1de284bf03b8&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44577&comment_hash=26501e3b991dc772a7bf296aa50a587a14e32533b4870591f6dc1de284bf03b8&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
