jsk1004ha commented on code in PR #43376:
URL: https://github.com/apache/superset/pull/43376#discussion_r4084112941
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -585,13 +589,21 @@ const SliceHeaderControls = (
label: (
<ModalTrigger
triggerNode={
- <div data-test="view-query-menu-item">{t('View query')}</div>
+ <div data-test="view-query-menu-item">{t('Query inspector')}</div>
}
- modalTitle={t('View query')}
+ modalTitle={t('Query inspector')}
modalBody={
<ViewQueryModal
latestQueryFormData={props.formData}
ownState={props.ownState}
+ queriesResponse={props.queriesResponse}
+ chartUpdateStartTime={props.chartUpdateStartTime}
+ chartUpdateEndTime={
+ props.chartStatus === 'stopped'
+ ? null
+ : props.chartUpdateEndTime
+ }
Review Comment:
Addressed in `97a8e62da`: renamed this to `Chart load time` and added a
tooltip to clarify that it includes client-side rendering. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
