craig-rueda commented on a change in pull request #8693: [jinja_context] Fix,
allow for app factory pattern
URL:
https://github.com/apache/incubator-superset/pull/8693#discussion_r352206879
##########
File path: superset/jinja_context.py
##########
@@ -209,6 +205,7 @@ def __init__(
"form_data": {},
}
self.context.update(kwargs)
+ BASE_CONTEXT.update(current_app.config["JINJA_CONTEXT_ADDONS"])
Review comment:
What about moving the initialization of the base context into the
AppInitializer? You could then expose the base context via extensions.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
