rusackas commented on PR #44501: URL: https://github.com/apache/superset/pull/44501#issuecomment-5801824860
This addresses both things I flagged, the `has_unparseable_statement` check and splitting out `REQUEST_CONTROLLABLE_MACROS` so `current_username()` isn't treated as attacker-controlled. Nice fix. Codeant's thread on the cleanly-parsed-only test coverage is still open. Looks handled by the fail-closed design already, but worth clearing before this merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
