rusackas commented on PR #44514: URL: https://github.com/apache/superset/pull/44514#issuecomment-5801833706
Heya @mikebridge, the shape here seems reasonable, the predicate plus the unit-of-work gate in particular. One thing I'd want sorted before this merges, though: the retention parsing. `0` disables, `-1` means purge on the next run, and any other negative is invalid but goes two different ways depending on which parser sees it (history skips, soft-delete falls back to 30). A `-1` sitting one keystroke from "disabled" is a scary sentinel for something that purges data, and the UPDATING entry spelling out the inconsistency reads like a thing to fix rather than document. Could we at least align the two parsers, and maybe reconsider whether core needs the immediate mode at all? Also, a handful of bito threads are still open (the `capture_enabled` session fallback one looks valid) plus your own two notes on the dataset wording. Mind assessing/resolving those? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
