altef commented on issue #8644: [SIP-29] Add support for row-level security
URL: 
https://github.com/apache/incubator-superset/issues/8644#issuecomment-559901374
 
 
   ### Proposed solution
   1. Row level security filters added to the Security menu:
   
![menu](https://user-images.githubusercontent.com/4316295/69893637-5743a980-12c9-11ea-8020-1f87f0c46c5d.jpg)
   
   2. Row level security list
   
![list](https://user-images.githubusercontent.com/4316295/69893640-6c203d00-12c9-11ea-9962-81a320ffc2cd.jpg)
   
   3. Row level security interface
   
![edit](https://user-images.githubusercontent.com/4316295/69893642-76dad200-12c9-11ea-8070-22f6f5f1d8cc.jpg)
   
   That allows for the management of the RowLevelSecurityFilters model.  
Additionally, for convenience, I've added it as a related view for tables.
   
   
![table-related-view](https://user-images.githubusercontent.com/4316295/69893652-a25dbc80-12c9-11ea-9f57-d2ec6b609315.jpg)
   
   After logging in with a user assigned to that role, I can still supply 
additional filters:
   
   
![additional-filters](https://user-images.githubusercontent.com/4316295/69893666-c91bf300-12c9-11ea-9504-6c1a20727307.jpg)
   
   The generated SQL includes the additional filters AND the clause supplied by 
the row level security filter(s).
   
   
![generated-sql](https://user-images.githubusercontent.com/4316295/69893678-e6e95800-12c9-11ea-82f6-5fe9160a7510.jpg)
   
   Everything seems to be working as expected on my end, and I'd be happy to 
provide a pull request if no one has any objections to this implementation?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to