toop commented on issue #8644: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/issues/8644#issuecomment-559903721 > > I've been looking into this with an eye toward implementing it, using a slightly different approach: > > ### Proposed Change > > > > 1. **Add a new model** to describe row level security filters, which references a Table and a Role. So when adding a row level security filter, you specify a particular Role and Table. > > 2. **Add the filters in to the query** when applicable. I've modified the [query function](https://github.com/apache/incubator-superset/blob/master/superset/connectors/sqla/models.py#L979) here to add any relevant to the WHERE clause. > > 3. **Create a UI for row level security filters.** I haven't started on this yet, in case I'm missing something and this method proves ill-advised. > > > > ### New or Changed Public Interfaces > > > > * New **row level security filters** interface > > > > ### New dependencies > > N/A > > ### Migration Plan and Compatibility > > TBD > > It all seems to be working as expected at this point. Does anyone foresee any obvious issues with this method? > > This sounds ideal. @toop any concerns with this revised approach? Agree to this revised ！This good ideal ！！！ Some proposals ： 1、Dynamic multi conditional support, such as, such as：“department = {user}.department，client_id =4” 2、Can support the datasources`s tables 3、Can add user attributes 4、FAB's empowerment view is too ugly and does not support 18in, improve FAB's authority view Thanks！！！
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
