glaterza commented on PR #44587: URL: https://github.com/apache/superset/pull/44587#issuecomment-5816822498
Thanks for picking this one up — this is the SQL Lab case from #44551. Heads-up on an overlap, and what I did about it: #44611 clears the fuzzy translations whose placeholders cannot format, and the Slovak `Running block %(block_num)s out of %(block_count)s` entry was in that set. Your fix is the better outcome for it — a correct Slovak translation beats falling back to English — so I removed that entry from my PR. The two changes are now independent and can land in either order without touching the same lines. One thing worth knowing for the test you added: the same defect class exists in 17 other languages for other strings, 36 of which raise on the backend. A check that covers every catalog and every msgid is PR 1 of the plan in #44551, and it flags 1,227 entries on master today. Happy to shape it around your test if you would rather have one mechanism than two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
