codeant-ai-for-open-source[bot] commented on code in PR #44397:
URL: https://github.com/apache/superset/pull/44397#discussion_r4095284199
##########
docs/developer_docs/contributing/howtos.md:
##########
@@ -323,6 +323,46 @@ pybabel extract -F babel.cfg -o
superset/translations/messages.pot -k lazy_gette
npm run build-translation
```
+### Adding context for translators
+
+A translatable string arrives in a catalog with no surrounding code, so a term
+that is unambiguous in context can be guessed wrong in isolation. Shipped
+examples include `Slug` rendered as the animal, `Host` as a guest, and
`Backend`
+as a driver.
+
+To attach context, put a comment tagged `i18n:` immediately above the string:
+
+```python
+# i18n: the short identifier in a dashboard's URL, not the animal
+"slug": _("Slug"),
+```
+
+```tsx
+// i18n: the database engine behind a connection (PostgreSQL, MySQL), not
+// a server tier or a driver
+Header: t('Backend'),
+```
+
+`babel_update.sh` extracts these with `--add-comments=i18n:`, so they land on
the
+entry in `messages.pot` as `#. i18n: ...` and `pybabel update` propagates them
Review Comment:
**Suggestion:** This says `babel_update.sh` extracts comments but gives no
command to run it; the documented extraction commands bypass it, so tagged
comments never reach `messages.pot`.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incomplete
implementation`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4e1a6baaf7d54aaeb428bb2047b03e74&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4e1a6baaf7d54aaeb428bb2047b03e74&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/developer_docs/contributing/howtos.md
**Line:** 346:347
**Comment:**
*Incomplete Implementation: This says `babel_update.sh` extracts
comments but gives no command to run it; the documented extraction commands
bypass it, so tagged comments never reach `messages.pot`.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44397&comment_hash=8164631ce6489247610e154b3c5d384e483619216b47d4326a750929b481eb31&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44397&comment_hash=8164631ce6489247610e154b3c5d384e483619216b47d4326a750929b481eb31&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
