codeant-ai-for-open-source[bot] commented on code in PR #44201:
URL: https://github.com/apache/superset/pull/44201#discussion_r4095360359
##########
.github/workflows/superset-frontend.yml:
##########
@@ -153,10 +153,11 @@ jobs:
run: |
zstd -d < docker-image.tar.zst | docker load
+ # The last weird node command is to run tests fo custom Superset lint
rules
- name: lint
run: |
docker run --rm $TAG bash -c \
- "npm i && npm run lint"
+ "npm i && npm run lint && node --import tsx --test
custom-lint-rules/**/*.test.ts"
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `a830f9f`.
The lint workflow now runs the custom lint-rule test suite with `node
--import tsx --test custom-lint-rules/**/*.test.ts` after the standard lint
command, so failures cause the Docker step to fail.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
