bito-code-review[bot] commented on PR #44616:
URL: https://github.com/apache/superset/pull/44616#issuecomment-5818430241
<!-- Bito Reply -->
The flagged issue is correct. While the current PR updates `BaseEngineSpec`
to wrap `JSONDecodeError` in `SupersetGenericDBErrorException`, engine-specific
overrides (like those for MySQL, Databricks, and Snowflake) that implement
their own `get_extra_params` or `update_params_from_encrypted_extra` methods
without calling the base implementation will still raise the raw
`JSONDecodeError`.
To resolve this, you should identify engine-specific classes that override
these methods and apply a similar `try-except` block to catch
`json.JSONDecodeError` and re-raise it as `SupersetGenericDBErrorException`.
Would you like me to fetch all other comments on this PR to validate them
and implement fixes for the remaining issues?
**superset/db_engine_specs/base.py**
```
except json.JSONDecodeError as ex:
logger.error(ex, exc_info=True)
raise SupersetGenericDBErrorException(message=str(ex)) from
ex
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
