gabotorresruiz commented on code in PR #44575:
URL: https://github.com/apache/superset/pull/44575#discussion_r4096733836
##########
docs/admin_docs/configuration/mcp-server.mdx:
##########
@@ -763,7 +763,7 @@ MCP_TOOL_SEARCH_CONFIG = {
"search_tool_name": "search_tools",
"call_tool_name": "call_tool",
"include_schemas": False, # False=summary mode (name + parameters_hint)
Review Comment:
Just a small NIT that does not hold up the approval, and the Bito run
flagged it too: fixing the table row two lines below left this example block
saying the opposite. It still has `"include_schemas": False` while the row now
documents the default as `True`.
I checked every other key in this block against `MCP_TOOL_SEARCH_CONFIG` in
`superset/mcp_service/mcp_config.py`, and `enabled`, `strategy`, `max_results`,
`always_visible`, `search_tool_name`, `call_tool_name`, `compact_schemas` and
`max_description_length` all match the shipped values. The `always_visible` row
also points back here with `See above`, so a reader does take this block as the
defaults. `include_schemas` is now the only key in it that disagrees with what
ships.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
