sadpandajoe opened a new pull request, #44621:
URL: https://github.com/apache/superset/pull/44621
### SUMMARY
Ports the last Cypress explore scenarios to Playwright, following the
existing component / page-object model, and removes the superseded Cypress spec
and helpers.
New specs in `playwright/tests/explore/`:
- `explore-save.spec.ts` — save as a new chart then overwrite it (exactly
one chart by name); save as while creating a new dashboard, then overwrite
selecting the existing dashboard (one chart, one dashboard, chart attached to
it). Overwrite responses are asserted successful.
- `cross-referenced-dashboards.spec.ts` — the metadata bar ("Not added to
any dashboard" / "Added to 1 dashboard" / "Added to N dashboards") and the "On
dashboards" submenu: empty state, listing, search with match / no results /
clear, and opening a dashboard link in a new tab.
- `explore-no-results.spec.ts` — a chart whose filter matches no rows shows
"No results were returned for this query".
Supporting page objects and helpers:
- `components/modals/SaveChartModal.ts` (extends `Modal`)
- `ExplorePage`: save button / save modal, metadata bar, actions menu and
"On dashboards" submenu helpers
- API helpers `getChartsByName` and `getDashboardsByName`
Removed: `cypress/e2e/explore/chart.test.js`,
`cypress/e2e/explore/utils.ts`,
`cypress/e2e/explore/visualizations/shared.helper.js` (no remaining importers).
The view-query and embed-code cases from the older Cypress link suite already
have RTL coverage and are not duplicated here.
Removing the remaining Cypress infrastructure will follow in a separate PR.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — test-only change.
### TESTING INSTRUCTIONS
```bash
cd superset-frontend
npx playwright test tests/explore --project=chromium
```
All 4 tests pass locally; each spec was also checked to fail when its key
assertion is broken.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
