mikebridge opened a new pull request, #44623: URL: https://github.com/apache/superset/pull/44623
### SUMMARY Follow-up to merged #44613 for [SC-121825](https://app.shortcut.com/preset/story/121825). Saving dashboard cross-filter scoping through `saveChartConfiguration` updates versioned `json_metadata` but did not advance the open Version History panel's refresh signal. Dispatch `dashboardSaveSucceeded(id)` only after that PUT succeeds, matching the other dashboard save paths. A failed save emits no refresh signal. Includes focused success/failure regression tests. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; there is no layout change. ### TESTING INSTRUCTIONS 1. Open a dashboard's Version History panel. 2. Change cross-filter scoping and save the dashboard; confirm the open panel refreshes to show the new version. 3. Confirm a failed save does not signal a completed save or refresh the panel. Local verification on apache master `96d31ee3`: red control failed the success regression with the dispatch removed (1 failed, 1 passed); restored candidate passed 26 tests in 3 focused Jest suites. Changed-file pre-commit passed, including frontend type checking. Local checks reused existing dependencies whose only package/lock difference from this master was ag-grid 36.1→36.2, unrelated to these files; exact-head CI remains the build authority. Independent React/Clean Code review found zero findings. ### ADDITIONAL INFORMATION - [x] Has associated issue: [SC-121825](https://app.shortcut.com/preset/story/121825) - [x] Required feature flags: `VERSION_HISTORY` to observe the panel - [x] Changes UI behavior without changing its layout - [ ] Includes DB Migration - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
