rusackas commented on PR #36708: URL: https://github.com/apache/superset/pull/36708#issuecomment-5824535028
Heya all, picking this up per @FelipeGLopez's go-ahead above. Rebased onto current `master` and reworked the mechanism: dropped `BroadcastChannel` (per my June comment and @geido's question on the re-fetch, that was more than this needed) in favor of having `refreshChart` fetch the chart's own current `params` from the server when "Force Refresh" is clicked, rather than pushing state across tabs live. Details in the updated PR description. That touches most of the files this PR previously changed, so the old inline threads are mostly against code that no longer exists. @msyavuz @alexandrusoare @geido, would appreciate a fresh look when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
