CodeWithPravinMaske commented on PR #44527:
URL: https://github.com/apache/superset/pull/44527#issuecomment-5824671566
@rusackas Took a look at SIP-116 (#26651) against this PR — here's the delta:
| SIP-116 ask | This PR |
|---|---|
| "Alternative time filter... commonly used calendar date picker" (cites an
Airbnb-style picker) | `Date range filter` — AntD `RangePicker`, a real
calendar-range control |
| "Fast navigation through months and years" | Built in — AntD's calendar
header has month/year jump controls |
| Replace the "scroll columns" design ("a nightmare on desktop") | No
column-scroll UI at all, just the calendar |
| "New dependencies... probably some UI lib" | None needed — AntD was
already a dependency |
| Rejected: slider-based picker | Not what we built |
| Doesn't specify new filter type vs. replacing the existing one | Went
additive — new `filter_date_range` type alongside Time Range, so existing
dashboards/filters are untouched |
So functionally this looks like a close match for the SIP's intent. The one
gap: the SIP doesn't explicitly ask for removing time-of-day, but that fell out
naturally from using a plain date picker rather than a datetime one — seems
like a reasonable bonus simplification rather than a divergence.
Happy to adjust anything if you see this differently before it goes to a
vote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
