younsl opened a new pull request, #390: URL: https://github.com/apache/superset-kubernetes-operator/pull/390
## Summary Follow-up to #386, split out as suggested in [review](https://github.com/apache/superset-kubernetes-operator/pull/386#pullrequestreview-5308811823). Operator replicas are active/standby: only the replica holding the [leader election Lease](https://kubernetes.io/docs/concepts/architecture/leases/#leader-election) reconciles. When leaderElection.enabled is false, every replica reconciles the same Superset resources and they race on Jobs, drains, and status. That combination is never valid, and #386 makes it more likely that people raise replicas, so the chart now fails rendering for replicas greater than 1 without leader election. ## Details - templates/deployment.yaml fails with "replicas > 1 requires leaderElection.enabled=true" when both conditions hold. Single-replica installs with leader election disabled keep rendering as before. - The leaderElection.enabled description in values.yaml now states the requirement, and the chart README is regenerated with [helm-docs](https://github.com/norwoodj/helm-docs). - New [helm-unittest](https://github.com/helm-unittest/helm-unittest) cases cover the failing combination, replicas 3 with leader election enabled, and replicas 0 with leader election disabled. - Upgrade note: an existing release that runs more than one replica with leader election disabled will now fail helm upgrade with the message above. Such a release is already racing, so the fix is to set leaderElection.enabled to true or scale to one replica. <details> <summary>Verification</summary> - helm unittest: 14 tests and 25 snapshots pass. - make helm-lint and make helm-values-covered pass. - helm template with values files (numbers parsed as float64, unlike the int64 path of set flags): replicas 2 with leader election disabled fails with the expected message, replicas 1 with it disabled and replicas 2 with it enabled render the expected replicas and leader-elect arguments. - make codegen leaves no diff beyond the regenerated README, and make lint-md passes. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
