kokhlo commented on PR #43960:
URL: https://github.com/apache/superset/pull/43960#issuecomment-5829456514
Thanks @rusackas — agreed on both counts. Verified your `3442a39` on the
branch: colon insertion on the way out of the tz-aware passthrough is the right
shape, and the `TS_REGEX` thread was indeed a nothing-burger (`export const`
was already there).
Ran the focused suite on top of it: `normalizeTimestamp.test.ts` 8/8, and
the whole `packages/superset-ui-core/test/time-format/` tree 158/158 —
including the instant-equivalence assertion (`new
Date(normalizeTimestamp('2026-01-15 12:30:00+0330'))` === `new
Date('2026-01-15T12:30:00+03:30')`) and the space-separated Trino cases.
One minor leftover if you care for a follow-up (not blocking, happy to leave
it): Bito flagged that `TS_REGEX_TZ_AWARE` also accepts the hybrid
`2023-03-11T12:00:00 +03:30` (T separator + space before offset), which `new
Date` can't parse — falls back to raw-string display rather than a wrong
instant, so I'd call it cosmetic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
