chadek commented on PR #44608:
URL: https://github.com/apache/superset/pull/44608#issuecomment-5833565505
Thanks for tracing each of these. All 8 are fixed in 338ead8684, covering
the two you'd block on and the four lower-stakes ones.
While re-running the rig to check the fixes I found one more leak, in the
same area as the launch/handshake one: even a passing run left a
/tmp/embedded-sdk-rig-* profile behind. stop() SIGKILLed only the main Chromium
process, and its helper processes kept writing into the profile after it was
removed. Chromium now runs in its own process group and is stopped as a group,
and the profile is only deleted once it has exited. SIGINT/SIGTERM stop it too,
since Ctrl-C no longer reaches a separate process group.
Checked locally with real Chromium:
- 39/39 on top of #44470
- Against master's src/, 18/37 with the failures reported and a tally at
the end. The rig still catches the bug; retrying errors didn't hide it.
- A navigation that destroys the page mid-poll: the poll retries and
recovers.
- Port 8100 already taken: clean error and exit 1.
- A fake Chromium whose connection fails, a nonexistent binary, and Ctrl-C
mid-run: all clean up, with no leftover process, temp directory or bound port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
