codeant-ai-for-open-source[bot] commented on code in PR #44664:
URL: https://github.com/apache/superset/pull/44664#discussion_r4108146001
##########
superset/common/query_context_processor.py:
##########
@@ -566,6 +566,15 @@ def get_data(
result = excel.df_to_excel(
df, index=include_index,
**current_app.config["EXCEL_EXPORT"]
)
+ # Explore Table / Pivot download uses this path (RESULTS +
XLSX),
+ # not apply_client_processing. Stamp formats and CF here.
+ form_data = self._query_context.form_data
+ if isinstance(form_data, dict) and isinstance(result, bytes):
+ from superset.utils.excel_conditional import
polish_explore_xlsx
+
+ result = polish_explore_xlsx(
+ result, df, form_data, include_index=include_index
+ )
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `c91cbe4`.
The XLSX export now passes the generated workbook, dataframe, and form data
to `polish_explore_xlsx`, which applies Explore display formats and conditional
formatting after serialization.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
