villebro commented on code in PR #44082:
URL: https://github.com/apache/superset/pull/44082#discussion_r4108782503
##########
superset/dashboards/api.py:
##########
@@ -1854,14 +1874,10 @@ def export_xlsx(self, pk: int) -> WerkzeugResponse:
$ref: '#/components/responses/404'
500:
$ref: '#/components/responses/500'
- 501:
- description: Excel export is not configured on this server
"""
- storage_config = current_app.config["EXPORT_STORAGE"]
- if not storage_config.get("bucket") or storage_config.get("backend")
is None:
- return self.response(
- 501, message="Excel export is not configured on this server."
- )
+ # Keep the request guards and two delivery paths together.
+ # Resolve the path once so its checks and delivery cannot diverge.
+ queued = is_export_storage_configured()
Review Comment:
It seems we're only checking that the storage flag is configured, but
shouldn't we also make sure Celery is available on the backend?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
