sadpandajoe opened a new pull request, #44669:
URL: https://github.com/apache/superset/pull/44669
### SUMMARY
Adds unit coverage for native filter config modal logic that had no tests:
- `hasCircularDependency` across acyclic, self-referential, 2-node, 3-node,
and diamond-shaped dependency graphs.
- The dependency picker excludes candidates that would introduce a cycle,
and validation flags only the filters that participate in a cycle.
- A removed filter's pending removal is finalized after its delay, and
restoring it before the delay cancels the removal.
- Save stays blocked while any filter has a validation error, and the
unsaved-changes state stays true while a filter removal is still pending.
Test-only change; no production code is modified. Each new test was checked
to fail when the production line it guards is broken.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TESTING INSTRUCTIONS
```
cd superset-frontend
npx jest
src/dashboard/components/nativeFilters/FiltersConfigModal/utils.test.ts \
src/dashboard/components/nativeFilters/FiltersConfigModal/hooks/useFilterOperations.test.ts
\
src/dashboard/components/nativeFilters/FiltersConfigModal/hooks/useModalSaveLogic.test.ts
```
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
