sadpandajoe opened a new pull request, #44673:
URL: https://github.com/apache/superset/pull/44673

   ### SUMMARY
   Adds coverage for drill to detail payloads and paging:
   
   - The drill to detail pane drops back to page 1 and refetches with the 
updated filter set when a drill filter is removed, and when the results are 
reloaded.
   - Right-clicking a Big Number trendline point stops the chart event and 
drills on that point, using the x-axis column (or the legacy time column when 
the x-axis is the timestamp alias) with the selected time grain.
   - The shared ECharts context menu handler builds drill to detail and drill 
by payloads from the clicked series.
   - Treemap context menu clicks produce drill filters for each level of the 
clicked path.
   
   Test-only change; no production code is modified. Each new assertion was 
verified to fail when the guarded production line is temporarily broken.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A (tests only)
   
   ### TESTING INSTRUCTIONS
   ```bash
   cd superset-frontend
   npm run test -- src/components/Chart/DrillDetail/DrillDetailPane.test.tsx 
plugins/plugin-chart-echarts/test/utils/eventHandlers.test.ts 
plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.test.tsx 
plugins/plugin-chart-echarts/test/Treemap/EchartsTreemap.test.tsx
   ```
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to