sadpandajoe opened a new pull request, #44676:
URL: https://github.com/apache/superset/pull/44676

   ### SUMMARY
   Adds coverage for native filter plugins and the horizontal filter bar 
overflow:
   
   - Focusing a filter that has overflowed into the "More filters" dropdown 
opens the dropdown; focusing a filter that is still in the main row does not, 
even when another filter has overflowed.
   - The select filter shows its one-line "+ N ..." overflow indicator in the 
horizontal bar and not in the vertical bar.
   - The time range filter emits `time_range` through the data mask when a 
range is chosen, and an empty value when it is cleared.
   - The time column filter (new test file) emits `granularity_sqla` for the 
synced selection and a null value when cleared.
   
   Test-only change; no production code is modified. Each new assertion was 
verified to fail when the guarded production line is temporarily broken.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A (tests only)
   
   ### TESTING INSTRUCTIONS
   ```bash
   cd superset-frontend
   npm run test -- 
src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.overflow.test.tsx
 src/filters/components/Select/SelectFilterPlugin.test.tsx 
src/filters/components/Time/TimeFilterPlugin.test.tsx 
src/filters/components/TimeColumn/TimeColumnFilterPlugin.test.tsx
   ```
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to