codeant-ai-for-open-source[bot] commented on code in PR #44604:
URL: https://github.com/apache/superset/pull/44604#discussion_r4109685879
##########
superset/mcp_service/sql_lab/schemas.py:
##########
@@ -72,9 +72,12 @@ class ExecuteSqlRequest(BaseModel):
limit: int | None = Field(
default=None,
description=(
- "Maximum number of rows to return. "
- "If not specified, respects the LIMIT in your SQL query. "
- "If specified, overrides any SQL LIMIT clause."
+ "Maximum rows returned. "
+ "Omitted: respects SQL LIMIT. "
+ "If set, caps the last statement's outer LIMIT at min(SQL LIMIT, "
+ "this value), adding one if absent. "
Review Comment:
**Suggestion:** The schema says an absent SQL limit adds one row, but
execution returns at most the requested limit, so clients receive inconsistent
limiting behavior.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e3ea4ffe0afa49b4a2a73cc4853c9d0e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e3ea4ffe0afa49b4a2a73cc4853c9d0e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/sql_lab/schemas.py
**Line:** 77:78
**Comment:**
*Api Mismatch: The schema says an absent SQL limit adds one row, but
execution returns at most the requested limit, so clients receive inconsistent
limiting behavior.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44604&comment_hash=0717c219173504c7d2cb241bf2596218782a79f6900abb2948447e0aa84e16dc&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44604&comment_hash=0717c219173504c7d2cb241bf2596218782a79f6900abb2948447e0aa84e16dc&reaction=dislike'>๐</a>
##########
superset/sql/parse.py:
##########
@@ -1770,22 +1780,65 @@ def _has_limit_by(self) -> bool:
def get_limit_value(self) -> int | None:
"""
- Parse a SQL query and return the `LIMIT` or `TOP` value, if present.
+ Return a fixed outer `LIMIT`, `TOP`, or `FETCH` row count, if known.
"""
# `LIMIT 2 BY id` bounds each group, not the result set, so reporting 2
# here would make `_set_query_limit()` clamp the whole query to 2 rows.
if self._has_limit_by():
return None
if limit_node := self._parsed.args.get("limit"):
- literal = limit_node.args.get("expression") or getattr(
- limit_node, "this", None
- )
+ options = limit_node.args.get("limit_options")
+ if options and (
+ options.args.get("percent") or options.args.get("with_ties")
+ ):
+ return None
+ if isinstance(limit_node, exp.Fetch):
+ literal = limit_node.args.get("count")
+ # FETCH FIRST ROW ONLY has an implicit count of one.
+ if literal is None:
+ return 1
+ else:
+ literal = limit_node.args.get("expression")
+ while isinstance(literal, exp.Paren):
+ literal = literal.this
if isinstance(literal, exp.Literal) and literal.is_int:
return int(literal.name)
return None
Review Comment:
**Suggestion:** Returning `None` for expression limits makes
`Database.apply_limit_to_sql` treat them as unlimited and replace a potentially
smaller existing limit.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=07017ff595e74a948770eddb89182833&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=07017ff595e74a948770eddb89182833&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/sql/parse.py
**Line:** 1805:1808
**Comment:**
*Api Mismatch: Returning `None` for expression limits makes
`Database.apply_limit_to_sql` treat them as unlimited and replace a potentially
smaller existing limit.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44604&comment_hash=990bd6b9970858a1a5ca40a2f2bfc97e7fac12209304309fdf276ca3b266dabe&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44604&comment_hash=990bd6b9970858a1a5ca40a2f2bfc97e7fac12209304309fdf276ca3b266dabe&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
