aminghadersohi commented on code in PR #44704:
URL: https://github.com/apache/superset/pull/44704#discussion_r4113366958
##########
tests/unit_tests/db_engine_specs/test_oracle.py:
##########
@@ -128,3 +128,50 @@ def test_denormalize_name(name: str, expected_result: str):
from superset.db_engine_specs.oracle import OracleEngineSpec as spec #
noqa: N813
assert spec.denormalize_name(oracle.dialect(), name) == expected_result
+
+
+def test_get_cancel_query_id() -> None:
+ from superset.db_engine_specs.oracle import OracleEngineSpec
+ from superset.models.sql_lab import Query
+
+ cursor = mock.Mock()
+ cursor.fetchone.return_value = (162, 53643, 1)
+ assert OracleEngineSpec.get_cancel_query_id(cursor, Query()) ==
"162,53643,1"
Review Comment:
`superset.models.sql_lab.Query` has no custom `__init__`; `Query()` builds a
transient instance without a session, and the same pattern is already used in
e.g. `test_snowflake.py`. These tests pass in CI (unit-tests job green), so no
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
