codeant-ai-for-open-source[bot] commented on code in PR #44734:
URL: https://github.com/apache/superset/pull/44734#discussion_r4118091862
##########
superset-frontend/src/utils/urlUtils.ts:
##########
@@ -291,10 +252,12 @@ export async function getDashboardPermalink({
*/
includeChartState?: boolean;
}): Promise<PermalinkResult> {
+ // Strip out any null or undefined values injected by the state manager
+ const sanitizedTabs = activeTabs ? activeTabs.filter(tab => tab != null) :
[];
Review Comment:
**Suggestion:** Converting null `activeTabs` to truthy `[]` makes permalink
hydration skip the dashboard’s default active tab, leaving no tab selected.
**Assessment:** 🟠 `Major` · 🔁 `Occurrence: Sometimes` · 🏷️ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5c8bbee0dd5b41ccad79fa3e166d91bc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5c8bbee0dd5b41ccad79fa3e166d91bc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/utils/urlUtils.ts
**Line:** 256:256
**Comment:**
*Logic Error: Converting null `activeTabs` to truthy `[]` makes
permalink hydration skip the dashboard’s default active tab, leaving no tab
selected.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44734&comment_hash=1777ab712f8ce6497cbaeece66ee9e5e5bc502971ebdba9b0c787d38c35fbf76&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44734&comment_hash=1777ab712f8ce6497cbaeece66ee9e5e5bc502971ebdba9b0c787d38c35fbf76&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
