codeant-ai-for-open-source[bot] commented on code in PR #44101:
URL: https://github.com/apache/superset/pull/44101#discussion_r4118788144
##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -521,6 +527,31 @@ const RightMenu = ({
}
});
+ const extensionSettingsItems = (settingsMenuExtension?.primary ?? [])
+ .map(menuItem => {
+ const command = commands.getCommand(menuItem.command);
+ if (!command) {
+ return null;
+ }
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag command lookups as stale references when the command registry
is a non-reactive Map and the surrounding menu configuration is already
reactive; only flag this as a broader issue when command-registry reactivity is
explicitly required.
**Applied to:**
- `superset-frontend/src/features/home/RightMenu.tsx`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
