aminghadersohi opened a new pull request, #44744: URL: https://github.com/apache/superset/pull/44744
### SUMMARY Align MCP chart queries with the frontend contracts: - Histogram selects observations and grouping columns and applies the histogram post-processing operator, including HAVING support. Previously generation failed with `Empty query?`. - Waterfall retains and orders its category and breakdown columns instead of returning only a grand total. - Histogram Vega-Lite previews render the computed bins/counts rather than treating bin counts as raw observations. - Treemap discovery examples use the object-shaped column/metric references required by the advertised JSON Schema. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No UI change. Live MCP checks previously failed Histogram generation and returned only `SUM(revenue)` for Waterfall; the corrected queries return histogram bins and per-category Waterfall rows. Both saved and unsaved Histogram previews use the same binned representation. ### TESTING INSTRUCTIONS - Query/schema regressions: 7 failing cases before the fix; preview regression: 1 failing case before the fix. - Focused helper, discovery, and preview tests: 159 passed after the fix. - `pre-commit run` passed on all seven changed files, including mypy and pylint. - Live streamable-HTTP MCP checks against a local Superset instance and real SQLite data: generate/save, update, compile/unsaved preview, URL/ASCII/table/Vega-Lite preview, JSON data, SQL, CSV and Excel exports, and discovery for Histogram, Waterfall, Bubble, Treemap, Gauge, and Gantt. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
