codeant-ai-for-open-source[bot] commented on code in PR #44746:
URL: https://github.com/apache/superset/pull/44746#discussion_r4119450149
##########
superset/mcp_service/chart/tool/update_chart_preview.py:
##########
@@ -195,21 +194,27 @@ def update_chart_preview( # noqa: C901
or (previous_form_data or {}).get("datasource_id")
or ""
).split("__", 1)[0]
+ plugin = get_registry().get(config.chart_type)
Review Comment:
**Suggestion:** Disabled saved chart plugins return `None` here, so their
required update hooks and compile checks are skipped even though saved charts
must retain their plugin behavior.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0f2752099c6248a2bb8dd771782704ce&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0f2752099c6248a2bb8dd771782704ce&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/chart/tool/update_chart_preview.py
**Line:** 197:197
**Comment:**
*Api Mismatch: Disabled saved chart plugins return `None` here, so
their required update hooks and compile checks are skipped even though saved
charts must retain their plugin behavior.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44746&comment_hash=1b54cfac2e32359cea497eae1e366de9109fc462c6affbe00823347e628f6983&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44746&comment_hash=1b54cfac2e32359cea497eae1e366de9109fc462c6affbe00823347e628f6983&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
