EnxDev commented on code in PR #44626: URL: https://github.com/apache/superset/pull/44626#discussion_r4121838676
########## UPDATING.md: ########## @@ -167,6 +167,24 @@ This fixed embedding cap is independent of the operator's `MCP_RESPONSE_SIZE_CONFIG['max_bytes']` (50,000 by default); it does not guarantee that every payload fits a configured response limit. +### Legacy FAB password reset pages are removed + +The Flask-AppBuilder server-rendered password reset pages at +`/resetpassword/form` (admin reset of another account) and +`/resetmypassword/form` (self-service reset) are no longer registered; both +routes answer 404, and the "Reset Password" and "Reset my password" buttons on +the legacy FAB user pages that led to them are gone. `superset init` no longer +assigns their permissions (`can this form get/post on ResetPasswordView` and +`ResetMyPasswordView`, plus the `resetpasswords` and `resetmypassword` actions on +`UserDBModelView`) to any role. Every flow they served lives in the SPA: +administrators reset a user's password from the "New password" fields in the +Users list edit modal (`PUT /api/v1/security/users/<id>`), users change their +own from the "Reset my password" modal on their profile page (`PUT +/api/v1/me/`, which requires `current_password`), and a pending forced password Review Comment: Nit, take it or leave it. `/api/v1/me/` only asks for `current_password` when the account already has one, so an operator on external auth could read this as those users being locked out. ```suggestion /api/v1/me/`, which requires `current_password` when the account already has one), and a pending forced password ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
