aminghadersohi commented on PR #44684: URL: https://github.com/apache/superset/pull/44684#issuecomment-5871576453
Taken both nits in a8c9ed3bd7542f813530818140d29c482cc912bf: both numeric checks use Real/Decimal (excluding bool), with a Decimal fallback regression test, and the return type is str | None. Chart tests: 2,153 passed, 3 skipped; pre-commit passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
