aminghadersohi commented on PR #44765:
URL: https://github.com/apache/superset/pull/44765#issuecomment-5865469175
About the CodeQL alert (`py/clear-text-logging-sensitive-data`,
`superset/models/core.py:1546`): it's a false positive.
- **The sink** is existing code in `Database.is_oauth2_enabled()`:
`logger.warning("Invalid OAuth2 client configuration for database %s", self)`.
This PR doesn't change it. `Database.__repr__` returns `self.name` (the verbose
name or `database_name`), so no credential is logged.
- **The "password" source** CodeQL reported is the new unit-test helper
`_oauth2_database()` in `tests/unit_tests/models/core_test.py`. CodeQL's
sensitive-data name heuristic classifies the name as a credential, then follows
the returned `Database` through `get_raw_connection()`/`get_inspector()` into
that log call. The SARIF code flow shows exactly this.
8f0f274 renames the helper to `_login_rejecting_database()`, with no
behaviour change, so the check should clear without a manual dismissal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
