codeant-ai-for-open-source[bot] commented on code in PR #38451:
URL: https://github.com/apache/superset/pull/38451#discussion_r4128541539
##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/types.ts:
##########
@@ -136,6 +138,8 @@ export const DEFAULT_FORM_DATA:
EchartsMixedTimeseriesFormData = {
zoomable: TIMESERIES_DEFAULTS.zoomable,
richTooltip: TIMESERIES_DEFAULTS.richTooltip,
showQueryIdentifiers: false,
+ truncateMetric: false,
+ truncateMetricB: false,
Review Comment:
Yes. `DEFAULT_FORM_DATA` should match the shared control default (`true`)
for consistency, particularly for legacy saved charts that lack these newly
introduced fields. Set both values to `true`:
```typescript
showQueryIdentifiers: false,
truncateMetric: true,
truncateMetricB: true,
```
This ensures the transform layer and Explore render the same series names
when the fields are omitted, avoiding a silent behavior change on re-save. The
explicit `false` case remains unaffected because supplied form data overrides
`DEFAULT_FORM_DATA`. Also verify/update the related tests and any documentation
that currently assumes truncation defaults to `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
