gkneighb commented on PR #43570: URL: https://github.com/apache/superset/pull/43570#issuecomment-5882847595
@rusackas Thanks — nothing blocking from my side, so it's good to merge whenever you are. On @gabotorresruiz's last comment: he explicitly flagged it as "not a blocker, and not something this PR broke". It's the sibling of the case this PR fixes — a `multi: false` `groupby` also stores a bare *object* (not just a string) when the Y axis is an adhoc or calculated column, so the coercion hands the query invented column names. Real, but pre-existing on master and orthogonal to the scalar-string fix here. I'd rather it get its own PR with its own test than be smuggled in. One thing I did push since your comment, at `2f6857a982`: the `exclude_unset=True` fix you asked for on #43573. `heatmap.py` had the identical shape, so the same one-word change plus a `test_merge_heatmap_preserves_omitted_row_limit` regression is now on this branch. (Heatmap has no `color_scheme` control, so only the row limit applies.) I audited all the registered plugins for it — details on #43573. CI is green at this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
