aminghadersohi commented on PR #44695: URL: https://github.com/apache/superset/pull/44695#issuecomment-5884237286
Addressed both asks in review run #99088b: the nanosecond timedelta64 conversion was already fixed in 6211f59beff6d8d7df526226a7015a38912eee29; the filtered “timedelta str breaks H:MM:SS” finding is fixed in d375346e02c06b7f3ae6ac62fde2d347531fbbbc. Durations use signed total hours, including multi-day values and fractional seconds, instead of Python’s day-prefixed representation. Added regressions for positive/negative multi-day values and microseconds (five cases failed before the fix). All 55 GSheets unit tests and configured pre-commit hooks, including mypy and ruff, pass. Merged origin/master in c65044a2e9 without rewriting existing commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
