aminghadersohi commented on PR #44714: URL: https://github.com/apache/superset/pull/44714#issuecomment-5884287342
Addressed all seven suggestions in the review summary, including the filtered suggestion, in 792e3b626d: - **Unbounded blocking wait:** replaced the private blocking wait with monotonic-deadline polling bounded by `SQLLAB_TIMEOUT`, with cancellation on expiry. Added a perpetually-pending timeout regression test and documented the polling/network timeout distinction. - **Private API coupling:** detect the public `execute_async` capability and use public `is_executing` / `execution_failed` methods; no access to `_wait_to_finish`. Tests cover synchronous cursors, pending asynchronous DML, asynchronous failures, and SELECT results. - **Broad exception catch:** catch only `impala.error.Error` during polling; TypeError and AttributeError are preserved, verified by parametrized tests. - **Unannotated attributes:** explicitly annotated description, error, and waited on the cursor double. - **Missing helper docstrings:** added docstrings to every cursor helper and new test helper. - **Inline import:** moved importlib to the module imports in test_base.py. - **Duplicate empty-description guard:** read and validate description once in BaseEngineSpec and reuse it for column normalization, removing the redundant fallback. Engine-specific duplicate guards remain removed. Merged origin/master with merge commit 222422dc69, preserving Oracle cancellation support while retaining the shared no-result-set guard. Validation: repository pre-commit hooks (including configured ruff and mypy) passed on all PR-changed Python files and the documentation change; 187 tests passed across test_base.py, test_impala.py, and test_oracle.py. No review threads exist to resolve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
