rusackas opened a new pull request, #44775:
URL: https://github.com/apache/superset/pull/44775
### SUMMARY
Adopts #38691 (originally by @ferjanin), rebased onto current `master` and
with the review feedback from that PR folded in.
`_get_tab_url()` in `superset/commands/report/execute.py` builds the
dashboard permalink used to screenshot a dashboard report when a tab or filter
state is set (`ALERT_REPORT_TABS`). It never propagated `force_screenshot`
("Ignore cache when generating report") into that URL, unlike the
plain-dashboard and chart report paths, which both already do this. So enabling
"Ignore cache" on a dashboard report with a tab/filter state selected was a
silent no-op.
This also pulls the repeated `force = "true" if
self._report_schedule.force_screenshot else "false"` ternary (previously
duplicated in `_get_url` and `get_dashboard_urls`) into one
`_get_force_param()` helper, now shared by all three URL builders, per the
dedup ask on the original PR.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - backend URL generation + test coverage only.
### TESTING INSTRUCTIONS
```
SUPERSET_HOME=/tmp/superset_test pytest -q
tests/unit_tests/commands/report/execute_test.py
SUPERSET_HOME=/tmp/superset_test pytest -q
tests/integration_tests/reports/commands/execute_dashboard_report_tests.py
```
Manually: enable "Ignore cache when generating report" on a dashboard report
whose `extra.dashboard` carries a tab/filter state, trigger it, and confirm the
permalink URL passed to the screenshot step includes `force=true`.
### ADDITIONAL INFORMATION
- [x] Has associated issue:
- Fixes #38672
- Supersedes #38691
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
