FrancescoCastaldi commented on PR #44464: URL: https://github.com/apache/superset/pull/44464#issuecomment-5887559292
@rusackas db5e1b4e slipped in while re-checking the older review round and re-applied two suggestions from the 09-21 review whose threads were already superseded and resolved. It also rejected the `[column, ascending]` pair documented in the `sort_by` description, dropped the covered-name/`saved_metric` handling in `extract_column_refs`, and broke pre-commit (E501 + a ruff-format diff). Reverted in 251ef2c, so the tree is identical to 81a94cc again. Scoped mcp_service suite: 552 passed, ruff clean. CI is rerunning on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
