FrancescoCastaldi commented on PR #44358: URL: https://github.com/apache/superset/pull/44358#issuecomment-5888149851
@rusackas removals are covered now (60c753c): `UpdateChartCommand` touches every dashboard whose link to the chart changed - the newly linked ones and the ones the chart was removed from - instead of only new associations. `test_update_chart_removing_dashboards_does_not_touch_remaining` became `test_update_chart_touches_dashboards_when_removed` and asserts the removed dashboard gets its `changed_on`/`changed_by` bumped while the dashboard keeping the chart stays untouched. Links that do not change are still left alone. Also tightened the touch assertions per @sadpandajoe's note above - each now seeds a prior `changed_on` and asserts it advanced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
