rusackas commented on PR #35610: URL: https://github.com/apache/superset/pull/35610#issuecomment-5893954473
Heya @tharani694, tried rebasing this and the conflict itself was small, but the functions it patches don't exist anymore. The whole async-query task system moved onto a Global Task Framework (#43407) since this opened, so `load_chart_data_into_cache`/`load_explore_json_into_cache` are gone. Nothing in the new framework has retry support built in either, so the gap's still real, just not something this diff can land on top of anymore. Also, @Antonio-RiveroMartnez's review from last November is still open: marking the job errored before a retry even runs means the frontend tears down its listener and never sees a later success. Worth designing around if this gets rebuilt. Setting this to draft for now. Let me know if you want to take a fresh pass at it against the new framework. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
