bito-code-review[bot] commented on PR #44715: URL: https://github.com/apache/superset/pull/44715#issuecomment-5897232665
<!-- Bito Reply --> The potential for alias collision is a valid concern. If the outer query binds `label__` to the inner subquery's alias, the join condition could indeed become tautological, leading to incorrect results. Using a more specific alias or a unique suffix for the series-limit subquery would prevent this collision. Adding a test case to `select_alias_shadowing_test.py` is recommended to verify this behavior and ensure the fix is robust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
